Do not create shortcut for missing target

git-svn-id: svn://tug.org/texlive/trunk@37234 c570f23f-e606-0410-a88d-b1316a301751

1 files changed, 8 insertions, 2 deletions

diff --git a/Master/tlpkg/TeXLive/TLUtils.pm b/Master/tlpkg/TeXLive/TLUtils.pm
index cf8389dbaac..af276fbaebc 100644
--- a/Master/tlpkg/TeXLive/TLUtils.pm
+++ b/Master/tlpkg/TeXLive/TLUtils.pm
@@ -1876,9 +1876,15 @@ sub _do_postaction_shortcut {
     # $cmd can be an URL, in which case we do NOT want to convert it to
     # w32 paths!
     if ($cmd !~ m!^\s*(http://|ftp://)!) {
+      if (!(-e $cmd) or !(-r $cmd)) {
+        tlwarn("Target of shortcut action does not exist: $cmd\n")
+            if $cmd =~ /\.(exe|bat|cmd)$/i;
+        # if not an executable, just omit shortcut silently
+        return 0;
+      }
       $cmd = conv_to_w32_path($cmd);
     }
-    if ($type eq "menu") {
+    if ($type eq "menu" ) {
       TeXLive::TLWinGoo::add_menu_shortcut(
                         $TeXLive::TLConfig::WindowsMainMenuName,
                         $name, $icon, $cmd, $args, $hide);
@@ -3522,7 +3528,7 @@ sub conv_to_w32_path {
   my $p = shift;
   # we need absolute paths, too
   my $pabs = tl_abs_path($p);
-  if (not defined $pabs) {
+  if (not $pabs) {
     $pabs = $p;
     tlwarn ("sorry, could not determine absolute path of $p!\n".
       "using original path instead");