From 38be9b849de4c215579c7f1e11df42ab23128bc7 Mon Sep 17 00:00:00 2001 From: Jérôme Laurens Date: Mon, 19 Jul 2010 22:10:34 +0000 Subject: Bug fix in synctex_parser.c, typos in comments in synctex.c (minor changes de facto, see the synctex_parser_readme.txt). TeX engines are not concerned so no need to recompile texlive, only 3rd party pdf viewers like Texworks, TeXShop, evince... are concerned. git-svn-id: svn://tug.org/texlive/trunk@19532 c570f23f-e606-0410-a88d-b1316a301751 --- Build/source/texk/web2c/synctexdir/synctex.c | 12 ++++++------ Build/source/texk/web2c/synctexdir/synctex_parser.c | 11 ++++++----- Build/source/texk/web2c/synctexdir/synctex_parser.h | 4 ++-- Build/source/texk/web2c/synctexdir/synctex_parser_readme.txt | 4 ++++ 4 files changed, 18 insertions(+), 13 deletions(-) (limited to 'Build/source') diff --git a/Build/source/texk/web2c/synctexdir/synctex.c b/Build/source/texk/web2c/synctexdir/synctex.c index 67dc8d510bb..ec8d847b5f2 100644 --- a/Build/source/texk/web2c/synctexdir/synctex.c +++ b/Build/source/texk/web2c/synctexdir/synctex.c @@ -810,8 +810,8 @@ void synctexteehs(void) static inline void synctex_record_vlist(halfword p); /* This message is sent when a vlist will be shipped out, more precisely at - * the beginning of the vliSYNCTEX_out procedure in *TeX.web. It will be balanced - * by a synctex_tsilv, sent at the end of the vliSYNCTEX_out procedure. p is the + * the beginning of the vlist_out procedure in *TeX.web. It will be balanced + * by a synctex_tsilv, sent at the end of the vlist_out procedure. p is the * address of the vlist We assume that p is really a vlist node! */ void synctexvlist(halfword this_box) { @@ -835,7 +835,7 @@ static inline void synctex_record_tsilv(halfword p); /* Recording a "f" line ending a vbox: this message is sent whenever a vlist * has been shipped out. It is used to close the vlist nesting level. It is - * sent at the end of the vliSYNCTEX_out procedure in *TeX.web to balance a former + * sent at the end of the vlist_out procedure in *TeX.web to balance a former * synctex_vlist sent at the beginning of that procedure. */ void synctextsilv(halfword this_box) { @@ -881,8 +881,8 @@ void synctexvoidvlist(halfword p, halfword this_box __attribute__ ((unused))) static inline void synctex_record_hlist(halfword p); /* This message is sent when an hlist will be shipped out, more precisely at - * the beginning of the hliSYNCTEX_out procedure in *TeX.web. It will be balanced - * by a synctex_tsilh, sent at the end of the hliSYNCTEX_out procedure. p is the + * the beginning of the hlist_out procedure in *TeX.web. It will be balanced + * by a synctex_tsilh, sent at the end of the hlist_out procedure. p is the * address of the hlist We assume that p is really an hlist node! */ void synctexhlist(halfword this_box) { @@ -906,7 +906,7 @@ static inline void synctex_record_tsilh(halfword p); /* Recording a ")" line ending an hbox this message is sent whenever an hlist * has been shipped out it is used to close the hlist nesting level. It is - * sent at the end of the hliSYNCTEX_out procedure in *TeX.web to balance a former + * sent at the end of the hlist_out procedure in *TeX.web to balance a former * synctex_hlist sent at the beginning of that procedure. */ void synctextsilh(halfword this_box) { diff --git a/Build/source/texk/web2c/synctexdir/synctex_parser.c b/Build/source/texk/web2c/synctexdir/synctex_parser.c index d6957009e88..060f32d12ad 100644 --- a/Build/source/texk/web2c/synctexdir/synctex_parser.c +++ b/Build/source/texk/web2c/synctexdir/synctex_parser.c @@ -1,12 +1,12 @@ /* -Copyright (c) 2008, 2009 jerome DOT laurens AT u-bourgogne DOT fr +Copyright (c) 2008, 2009; 2010 jerome DOT laurens AT u-bourgogne DOT fr This file is part of the SyncTeX package. -Version: 1.9 +Version: 1.12 See synctex_parser_readme.txt for more details -Latest Revision: Wed Jul 1 11:18:18 UTC 2009 +Latest Revision: Mon Jul 19 21:50:36 UTC 2010 License: -------- @@ -2544,9 +2544,9 @@ int __synctex_open(const char * output, char ** synctex_name_ref, gzFile * file_ int __synctex_open(const char * output, char ** synctex_name_ref, gzFile * file_ref, synctex_bool_t add_quotes, synctex_io_mode_t * io_modeRef) { # define synctex_name (*synctex_name_ref) # define the_file (*file_ref) -# define io_mode (*io_modeRef) if(synctex_name_ref && file_ref) { char * quoteless = NULL; + synctex_io_mode_t io_mode = *io_modeRef; const char * mode = synctex_io_modes[io_mode]; size_t size = 0; /* now create the synctex file name */ @@ -2650,12 +2650,13 @@ return_on_error: quoteless = NULL; } } + /* We are returning properly so we can also return the proper io_mode */ + *io_modeRef = io_mode; return 0; } return 3; /* Bad parameter. */ # undef synctex_name # undef the_file -# undef io_mode } /* Opens the ouput file, taking into account the eventual build_directory. diff --git a/Build/source/texk/web2c/synctexdir/synctex_parser.h b/Build/source/texk/web2c/synctexdir/synctex_parser.h index a8e07dfbc6f..b164b7fb4c3 100644 --- a/Build/source/texk/web2c/synctexdir/synctex_parser.h +++ b/Build/source/texk/web2c/synctexdir/synctex_parser.h @@ -1,11 +1,11 @@ /* -Copyright (c) 2008, 2009 jerome DOT laurens AT u-bourgogne DOT fr +Copyright (c) 2008, 2009, 2010 jerome DOT laurens AT u-bourgogne DOT fr This file is part of the SyncTeX package. Latest Revision: Wed Jul 1 11:16:51 UTC 2009 -Version: 1.8 +Version: 1.12 See synctex_parser_readme.txt for more details License: diff --git a/Build/source/texk/web2c/synctexdir/synctex_parser_readme.txt b/Build/source/texk/web2c/synctexdir/synctex_parser_readme.txt index 613bc304821..68c915f3425 100644 --- a/Build/source/texk/web2c/synctexdir/synctex_parser_readme.txt +++ b/Build/source/texk/web2c/synctexdir/synctex_parser_readme.txt @@ -105,6 +105,10 @@ Note that version 1.7 was delivered privately. 1.11: Sun Jan 17 09:12:31 UTC 2010 - Bug fix in synctex_parser.c, function synctex_node_box_visible_v: 'x' replaced by 'y'. Only 3rd party tools are concerned. +1.12: Mon Jul 19 21:52:10 UTC 2010 +- Bug fix in synctex_parser.c, function __synctex_open: the io_mode was modified even in case of a non zero return, +causing a void .synctex.gz file to be created even if it was not expected. Reported by Marek Kasik concerning a bug on evince. + Only 3rd party tools are concerned. Acknowledgments: ---------------- -- cgit v1.2.3