start pdf_warning(s) at the beginning of a terminal output line

git-svn-id: svn://tug.org/texlive/trunk@60605 c570f23f-e606-0410-a88d-b1316a301751

3 files changed, 18 insertions, 8 deletions

diff --git a/Build/source/texk/web2c/pdftexdir/ChangeLog b/Build/source/texk/web2c/pdftexdir/ChangeLog
index d9adc6ab40e..73e37b6ab9d 100644
--- a/Build/source/texk/web2c/pdftexdir/ChangeLog
+++ b/Build/source/texk/web2c/pdftexdir/ChangeLog
@@ -1,3 +1,13 @@
+2021-09-25  Karl Berry  <karl@freefriends.org>
+
+	* pdftex.web: always call pdf_warning with prepend_nl true,
+	to avoid warnings showing up in the midst of the output, e.g., from:
+        '\pdfoutput=1 \noindent \pdfstartlink goto num 99\pdfendlink'
+
+	This might cause a blank line, but doing the test as in print_nl
+	to check if we are already at the beginning of the terminal line
+	seems too intrusive at this late date, affecting other messages.
+
 2021-09-03  Thanh Han The  <hanthethanh@gmail.com>
 
 	* pdftex.web (prev_tail): new global.
diff --git a/Build/source/texk/web2c/pdftexdir/NEWS b/Build/source/texk/web2c/pdftexdir/NEWS
index 28e77abde27..5c552424d32 100644
--- a/Build/source/texk/web2c/pdftexdir/NEWS
+++ b/Build/source/texk/web2c/pdftexdir/NEWS
@@ -1,6 +1,7 @@
 pdfTeX 3.141592653-2.6-1.40.23 (TeX Live 2021 post-release) (June 28, 2021)
 - changes:
   - for letterspaced fonts, use explicit \fontdimen6 if specified.
+  - always start a warning at the beginning of a line.
 
 - bugfixes:
   - make .fmt files sharable between 4/8-byte architectures.
diff --git a/Build/source/texk/web2c/pdftexdir/pdftex.web b/Build/source/texk/web2c/pdftexdir/pdftex.web
index 44f464420fe..b62bc56b585 100644
--- a/Build/source/texk/web2c/pdftexdir/pdftex.web
+++ b/Build/source/texk/web2c/pdftexdir/pdftex.web
@@ -17247,7 +17247,7 @@ var kn, st, sh: scaled;
     f: internal_font_number;
 begin
     if not (not is_char_node(g) and type(g) = glue_node) then begin
-        pdf_warning("adjust_interword_glue", "g is not a glue", false, false);
+        pdf_warning("adjust_interword_glue", "g is not a glue", true, true);
         return;
     end;
 
@@ -17610,8 +17610,7 @@ begin
     end
     else begin
         if (pdf_font_type[f] <> new_font_type) and (pdf_font_type[f] <> virtual_font_type) then
-            pdf_warning("font expansion", "font should be expanded before its first use",
-                        true, true);
+            pdf_warning("font expansion", "font should be expanded before its first use", true, true);
         set_expand_params(f, auto_expand, stretch_limit, shrink_limit, font_step, 0);
         if pdf_font_type[f] = virtual_font_type then
             vf_expand_local_fonts(f);
@@ -19877,7 +19876,7 @@ PDF browsers, so we need to fix them.
 begin
     if obj_dest_ptr(k) <> null then
         return;
-    pdf_warning("dest", "", false, false);
+    pdf_warning("dest", "", true, false);
     if obj_info(k) < 0 then begin
         print("name{");
         print(-obj_info(k));
@@ -19906,7 +19905,7 @@ end
 @ @<Check for non-existing pages@>=
 k := head_tab[obj_type_page];
 while obj_aux(k) = 0 do begin
-    pdf_warning("dest", "Page ", false, false);
+    pdf_warning("dest", "Page ", true, false);
     print_int(obj_info(k));
     print(" has been referenced but does not exist!");
     print_ln; print_ln;
@@ -19949,7 +19948,7 @@ for k := font_base + 1 to font_ptr do
             pdf_font_attr[k] := pdf_font_attr[i]
         else if (length(pdf_font_attr[i]) <> 0) and (length(pdf_font_attr[k]) <> 0) and
            not str_eq_str(pdf_font_attr[i], pdf_font_attr[k]) then begin
-           pdf_warning("\pdffontattr", "fonts ", false, false);
+           pdf_warning("\pdffontattr", "fonts ", true, false);
            print_font_identifier(i);
            print(" and ");
            print_font_identifier(k);
@@ -34795,7 +34794,7 @@ procedure warn_dest_dup(id: integer; byname: small_number; s1, s2: str_number);
 begin
     if pdf_suppress_warning_dup_dest > 0 then
         return;
-    pdf_warning(s1, "destination with the same identifier (", false, false);
+    pdf_warning(s1, "destination with the same identifier (", true, false);
     if byname > 0 then begin
         print("name");
         print_mark(id);
@@ -35207,7 +35206,7 @@ end;
 procedure pdf_fix_thread(thread: integer);
 var a: pointer;
 begin
-    pdf_warning("thread", "destination ", false, false);
+    pdf_warning("thread", "destination ", true, false);
     if obj_info(thread) < 0 then begin
         print("name{");
         print(-obj_info(thread));