(all_files): implement.

git-svn-id: svn://tug.org/texlive/trunk@4586 c570f23f-e606-0410-a88d-b1316a301751

1 files changed, 11 insertions, 11 deletions

diff --git a/Master/tlpkg/TeXLive/TLPOBJ.pm b/Master/tlpkg/TeXLive/TLPOBJ.pm
index 35a989d6527..623b278a97b 100644
--- a/Master/tlpkg/TeXLive/TLPOBJ.pm
+++ b/Master/tlpkg/TeXLive/TLPOBJ.pm
@@ -7,8 +7,7 @@
 package TeXLive::TLPOBJ;
 
 use TeXLive::TLUtils;
-#use TeXLive::TeXCatalogue; -- requires XML::DOM, we only want it at
-#update time.
+#use TeXLive::TeXCatalogue; -- we only want to require XML::DOM at update time.
 use File::Path;
 use Cwd;
 use TeXLive::TLTREE;
@@ -35,7 +34,7 @@ sub new {
     docfiles    => defined($params{'docfiles'}) ? $params{'docfiles'} : [],
     docsize   => $params{'docsize'},
     executes    => defined($params{'executes'}) ? $params{'executes'} : [],
-    # note that binfiles is an ARRAY with keys of $arch!
+    # note that binfiles is a HASH with keys of $arch!
     binfiles    => defined($params{'binfiles'}) ? $params{'binfiles'} : {},
     binsize     => defined($params{'binsize'}) ? $params{'binsize'} : {},
     depends     => defined($params{'depends'}) ? $params{'depends'} : [],
@@ -201,14 +200,8 @@ sub from_fh {
 
 sub recompute_revision {
   my ($self,$tltree) = @_;
-  my @files;
-  foreach my $a (keys %{$self->{'binfiles'}}) {
-    push @files, @{$self->{'binfiles'}{$a}};
-  }
-  push @files, $self->runfiles;
-  push @files, $self->docfiles;
-  push @files, $self->srcfiles;
-  $filemax = 0;
+  my @files = $self->all_files;
+  my $filemax = 0;
   foreach my $f (@files) {
     $filemax = $tltree->file_svn_lastrevision($f);
     $self->revision(($filemax > $self->revision) ? $filemax : $self->revision);
@@ -561,6 +554,13 @@ sub all_files {
   push (@ret, $self->docfiles);
   push (@ret, $self->runfiles);
   push (@ret, $self->srcfiles);
+  
+  my %binfiles = %{$self->binfiles};
+  for my $arch (keys %binfiles) {
+    push (@ret, @{$binfiles{$arch}});
+  }
+  
+  return @ret;
 }